Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-bte operations for BioThings PFOCR chebi/doid fields #882

Closed
colleenXu opened this issue Oct 7, 2024 · 3 comments
Closed

Add x-bte operations for BioThings PFOCR chebi/doid fields #882

colleenXu opened this issue Oct 7, 2024 · 3 comments
Labels
On Test Related changes are deployed to Test server x-bte

Comments

@colleenXu
Copy link
Collaborator

Would need to do on branch/use overrides in BTE.

chebi (chem) and doid (disease) fields are live on pending-BioThings CI right now.

Here are examples:

@colleenXu colleenXu added the x-bte label Oct 7, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented Oct 18, 2024

Track the deployment of pending BioThings API in biothings/pending.api#241?

@colleenXu
Copy link
Collaborator Author

@tokebe

Should be ready to add the override PR to CI. But need @ctrl-schaff @newgene to chime in on whether PFOCR update (biothings/pending.api#241?) is going to be in upcoming CI -> Test deployment.

I tested the updated yaml and it's all good. Set up a yaml PR update for the future, after pending BioThings API is updated in all instances.

@colleenXu colleenXu added On CI Related changes are deployed to CI server On CI -> Test and removed On CI Related changes are deployed to CI server labels Oct 22, 2024
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI -> Test labels Oct 28, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented Oct 30, 2024

I've updated the master branch yaml (merged PR) so all instances of BTE/Service Provider will start using this after the SmartAPI registry auto-refreshes (midnight Pacific?).

This is okay because...

  • all instances of the BioThings PFOCR API have been updated with new data and the chebi/doid fields. (Test, Prod - transltr.io, Prod - ncats.io)
  • I confirmed this by checking each instances'...
    • metadata/fields response: all list chebi and doid fields
    • /geneset/PMC10967338__antibodies-13-00025-g003. All had this figure's data, including values in the chebi and doid fields

But remember, we can't close the branch NCATS-Tangerine/translator-api-registry#159 until BTE/Service Provider's overrides are removed in all instances or that infrastructure is defunct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Test Related changes are deployed to Test server x-bte
Projects
None yet
Development

No branches or pull requests

2 participants