Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary config changes (rolling deployment chore) #811

Open
colleenXu opened this issue Apr 18, 2024 · 4 comments
Open

Remove temporary config changes (rolling deployment chore) #811

colleenXu opened this issue Apr 18, 2024 · 4 comments

Comments

@colleenXu
Copy link
Collaborator

colleenXu commented Apr 18, 2024

Often, we use temporary overrides or other config adjustments to handle the staggered deployment of features (Dev -> CI -> Test -> Prod). We direct BTE to use updated/changed SmartAPI yamls.

Once the features are deployed to Prod (on all instances), we have a chore to remove them:

  • make the changes into the default
    • merge the SmartAPI yaml changes to the master branch (registered yamls)
    • for TRAPI updates, update the registered yaml to latest TRAPI + all server urls. Then delete the temporary registrations used in the exclusions
  • remove the temporary overrides or other config adjustments
  • put into the next deployment cycle

We can't remove SmartAPI yaml branches used for the temporary overrides until the overrides have been removed from all instances.

@colleenXu
Copy link
Collaborator Author

For the current Translator Sprint (2/Octopus):

@colleenXu
Copy link
Collaborator Author

colleenXu commented Jun 14, 2024

Update: sprint 2/Octopus has deployed to Prod.

We've decided to add this chore to Eel the patch we're doing to Octopus with this PR biothings/bte-server#30:

EDIT: Done 7/31. Once the patch is deployed on all instances, then I can merge this PR to update BioThings PFOCR's registered yaml (which all instances will be using): NCATS-Tangerine/translator-api-registry#153

@tokebe
Copy link
Member

tokebe commented Jul 26, 2024

Eel changes deployed to Prod, resetting tracking label.

@colleenXu
Copy link
Collaborator Author

colleenXu commented Oct 30, 2024

@tokebe

If we do any hot-fixes/ CI -> Test deployments for this last sprint / end of phase, can we include biothings/bte-server#51?

It's fine to do because I've already merged the PFOCR yaml update to master. So these changes are live on all instances already. See more notes in #882 (comment)


Documenting our decision on the other overrides...

We agreed to keep the overrides for "removing clinical trial operations" for this phase:

  • we can't merge the yaml changes early - because then Prod will be affected and lose all clinical trial data
  • we don't know if they'll still want us to use Multiomics CTKP exclusively for clinical trials data next phase. Once we know, then we can decide to merge the yaml changes or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants