Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node attributes module #302

Closed
colleenXu opened this issue Sep 20, 2021 · 6 comments
Closed

Adding node attributes module #302

colleenXu opened this issue Sep 20, 2021 · 6 comments
Assignees

Comments

@colleenXu
Copy link
Collaborator

After talking with Andrew, here are the current ideas:

  • this module can be "executed alone / independently", aka it can take an arbitrary TRAPI response with a message.knowledge_graph.nodes section and return the TRAPI response with node attributes added to the nodes
  • we would plan to use this module internally (probably as a step at the end of the query process, like results assembly)

Here are some topics we may want to work through:

  • what info we want as node attributes (from what is available in biothings APIs...)
  • How will we retrieve this info, starting from the node IDs / semantic types?
  • ideally the node attributes will have "attribute_type_id" values that match what Translator expects. This will have to be set somewhere in the new code...and This involves some review with @colleenXu.
@colleenXu
Copy link
Collaborator Author

Note that the code will likely be very similar to the old ID resolver, but focused on node attributes rather than finding equivalent IDs

@colleenXu
Copy link
Collaborator Author

@colleenXu
Copy link
Collaborator Author

@marcodarko some feedback: I'd like clear documentation (here on the issue, a README, a doc, something) on how to add / edit node attributes. I think that would make it easier for me and Andrew to contribute.

@andrewsu
Copy link
Member

node attributes are handled in https://github.com/biothings/biomedical_id_resolver.js/blob/main/src/config.ts with the mappings under additional_attributes_mapping

@marcodarko
Copy link
Contributor

Also related to this issue: biothings/call-apis.js#34 linking for ref.

@colleenXu
Copy link
Collaborator Author

I'm closing this ticket since it's been deployed.

However, I plan to open a new ticket for reviewing the node attributes / perhaps adding some more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants