Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #209 #14

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Fix #209 #14

merged 1 commit into from
Aug 16, 2021

Conversation

ericz1803
Copy link
Contributor

Fix biothings/biothings_explorer#209.

Looks like 'name' was renamed to 'original_attribute_name' in the attributes object

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1129271972

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.267%

Totals Coverage Status
Change from base Build 1111617857: 0.0%
Covered Lines: 278
Relevant Lines: 306

💛 - Coveralls

@colleenXu
Copy link
Contributor

It's correct that the TRAPI spec for Attribute no longer has "name" as a property. Instead:

  • "attribute_type_id" is supposed to say what the attribute is (although Automat is just putting "biolink:Attribute" here which doesn't say what exactly is there...)
  • "original_attribute_name" is supposed to be what the data / knowledge source actually calls this edge property / association property / piece of info.

It would still have to be discussed with Andrew / Chunlei, but I've been thinking that BTE should do something similar to Automat - rather than its current behavior of dealing with Attributes it gets from non-TRAPI APIs.

@newgene newgene merged commit 4152a50 into biothings:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] missing Automat publications (and other attributes)
4 participants