Add not_notable to CurationRelevance vocabulary for semi-automated curation workflow
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 42.51% 43.49% +0.98%
==========================================
Files 117 118 +1
Lines 8327 8191 -136
Branches 1963 1346 -617
==========================================
+ Hits 3540 3563 +23
+ Misses 4582 4464 -118
+ Partials 205 164 -41 ☔ View full report in Codecov by Sentry. |
bgyori
reviewed
Oct 30, 2024
| @@ -37,3 +37,5 @@ class CurationRelevance(str, enum.Enum): | |||
| unclear = enum.auto() | |||
| #: Completely unrelated information | |||
| irrelevant_other = enum.auto() | |||
| #: Relevant for training purposes, but not curated in Bioregistry due to poor/unknown quality | |||
| not_notable = enum.auto() | |||
There was a problem hiding this comment.
Is this the only place we need to add this? I seem to recall also having this info duplicated in the documentation?
There was a problem hiding this comment.
Yes, it also needs to be updated in #1195. I will update that PR separately
There was a problem hiding this comment.
Okay, let's merge this first then and also add it on the other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
not_notabletag to the CurationRelevance vocabulary as a way to mark papers that are relevant for machine learning training but do not meet the threshold for inclusion in the Bioregistry.While curating papers, there have been a few instances of entries that provide new identifier information but aren't notable enough, or well-maintained enough for inclusion in the bioregistry (#1225). Rather than curating these as subpar prefixes, tagging them as
not_notableallows us to retain them as positive training samples without cluttering the bioregistry with less impactful entries.