Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit recent python changes #1201

Open
cthoyt opened this issue Oct 11, 2024 · 0 comments
Open

Audit recent python changes #1201

cthoyt opened this issue Oct 11, 2024 · 0 comments

Comments

@cthoyt
Copy link
Member

cthoyt commented Oct 11, 2024 •
edited
Loading

0f3d4fb is one of the last commits I made before I wasn't tracking changes during sabbatical. To see changes to all Python files made since then, run
git diff --name-only 0f3d4fbe9 HEAD -- "*.py". This gives:

docs/source/conf.py
src/bioregistry/analysis/bioregistry_diff.py
src/bioregistry/analysis/paper_ranking.py
src/bioregistry/analysis/title_tfidf.py
src/bioregistry/cli.py
src/bioregistry/curation/suggest_author_curation.py
src/bioregistry/external/ols/__init__.py
src/bioregistry/external/wikidata/__init__.py
src/bioregistry/gh/new_prefix.py
src/bioregistry/schema/struct.py
src/bioregistry/version.py
tests/test_data.py
@cthoyt cthoyt mentioned this issue Nov 4, 2024
Merged
cthoyt added a commit that referenced this issue Nov 4, 2024
@cthoyt
Add more strict typing (#1253)
9900364 
Related to #1201, the Bioregistry codebase already started to get unruly
when I wasn't able to give consistent code quality reviews. Moving
towards making all files being strictly typed is the next big step
towards making it more sustainable. This is a first step towards that.
It focuses on making sure that students might touch has the highest
amount of checks on it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cthoyt