Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): add ROME MIT license #949

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(package): add ROME MIT license #949

merged 1 commit into from
Nov 28, 2023

Conversation

Conaclos
Copy link
Member

Summary

Address one of the point highlighted in #911

@Conaclos Conaclos requested a review from ematipico November 28, 2023 19:57
@Conaclos Conaclos temporarily deployed to Website deployment November 28, 2023 19:57 — with GitHub Actions Inactive
@Conaclos Conaclos force-pushed the conaclos/npm/rome-license branch from e5da941 to 028106f Compare November 28, 2023 19:59
@Conaclos Conaclos temporarily deployed to Website deployment November 28, 2023 20:02 — with GitHub Actions Inactive
ematipico
ematipico reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend-jsonrpc should be updated too

@Conaclos Conaclos force-pushed the conaclos/npm/rome-license branch from 028106f to 4835a34 Compare November 28, 2023 21:03
@Conaclos Conaclos temporarily deployed to Website deployment November 28, 2023 21:03 — with GitHub Actions Inactive
@Conaclos Conaclos merged commit c3f6b3c into main Nov 28, 2023
8 checks passed
@Conaclos Conaclos deleted the conaclos/npm/rome-license branch November 28, 2023 22:47
@nissy-dev nissy-dev mentioned this pull request Nov 29, 2023
Closed
@strager
Copy link
Contributor

strager commented Dec 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conaclos @strager @ematipico