fix(tooling): update the script to bump the nightly version #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this fix :) I think we should bump the minor version instead of the patch. What do you think @ematipico? |
|
I don't have options, any version is fine as long as it is higher than the previous |
@chansuke |
|
@Conaclos I think that patch is better option |
|
Nightly version could also just be date time based |
Conaclos
approved these changes
Nov 25, 2023
ematipico
pushed a commit
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #860.
Bump
versionof nightly in the script.Test Plan