fix(js_formatter): disambiguate parametrized arrow functions and JSX elements #872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #832 and the following divergences:
Useless trailing commas are now removed in type parameter lists.
We keep the trailing comma in the case where:
extends
clause).cts
ormts
.The last condition requires introducing a new language variant, I named
StandardRestricted
.This variant doesn't allow JSX, but adds extra restriction to be future-proof (if one day TSC decides to allow JSX for these extensions).
See the related Prettier changelog line and TypeScript design notes.
Test Plan