feat(lint): implement a useRegexLiterals rule #843
Merged
+6,988
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Conaclos
reviewed
Nov 23, 2023
|
@Conaclos |
Conaclos
reviewed
Nov 24, 2023
Comment on lines
208
to
209
| let expr = from.as_any_js_expression()?; | ||
| match expr.clone().omit_parentheses() { |
There was a problem hiding this comment.
To avoid the clone we could write:
Suggested change
| let expr = from.as_any_js_expression()?; | |
| match expr.clone().omit_parentheses() { | |
| let AnyJsCallArgument::AnyJsExpression(expr) = from else { return None }; | |
| match expr..omit_parentheses() { |
Comment on lines
210
to
235
| AnyJsExpression::AnyJsLiteralExpression(expr) => { | ||
| let expr = expr.as_js_string_literal_expression()?; | ||
| let text = expr.inner_string_text().ok()?; | ||
| Some(text.to_string()) | ||
| } | ||
| AnyJsExpression::JsTemplateExpression(expr) => { | ||
| let elements = expr.elements(); | ||
| if !elements | ||
| .iter() | ||
| .all(|elem| matches!(elem, AnyJsTemplateElement::JsTemplateChunkElement(_))) | ||
| { | ||
| return None; | ||
| } | ||
|
|
||
| let text = elements | ||
| .iter() | ||
| .filter_map(|elem| { | ||
| elem.as_js_template_chunk_element() | ||
| .unwrap() | ||
| .template_chunk_token() | ||
| .ok() | ||
| }) | ||
| .map(|elem| elem.text().replace('\n', "\\n")) | ||
| .collect::<String>(); | ||
|
|
||
| Some(text) |
There was a problem hiding this comment.
I think you could reuse as_static_value() that is defined in biome_js_syntax/src/expr_ext.rs. And check that the returned static value is a string ``StaticValue::String. Basically as_static_value()` returns `SttaicValue::String` for a string literal and a template literal that consists of a single chunk.
There was a problem hiding this comment.
I refactored codes using it at e0ec310
Thank you for letting me know.
Comment on lines
241
to
251
| fn extract_inner_text(expr: &JsComputedMemberExpression) -> Option<String> { | ||
| let text = expr | ||
| .member() | ||
| .ok()? | ||
| .as_any_js_literal_expression()? | ||
| .as_js_string_literal_expression()? | ||
| .inner_string_text() | ||
| .ok()? | ||
| .to_string(); | ||
| Some(text) | ||
| } |
There was a problem hiding this comment.
To avoid the string allocation you can return a TokenText:
Suggested change
| fn extract_inner_text(expr: &JsComputedMemberExpression) -> Option<String> { | |
| let text = expr | |
| .member() | |
| .ok()? | |
| .as_any_js_literal_expression()? | |
| .as_js_string_literal_expression()? | |
| .inner_string_text() | |
| .ok()? | |
| .to_string(); | |
| Some(text) | |
| } | |
| fn extract_inner_text(expr: &JsComputedMemberExpression) -> Option<TokenText> { | |
| expr | |
| .member() | |
| .ok()? | |
| .as_any_js_literal_expression()? | |
| .as_js_string_literal_expression()? | |
| .inner_string_text() | |
| .ok() | |
| } |
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
of use_regex_literals
Yuiki
commented
Nov 24, 2023
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
Comment on lines
241
to
251
| fn extract_inner_text(expr: &JsComputedMemberExpression) -> Option<String> { | ||
| let text = expr | ||
| .member() | ||
| .ok()? | ||
| .as_any_js_literal_expression()? | ||
| .as_js_string_literal_expression()? | ||
| .inner_string_text() | ||
| .ok()? | ||
| .to_string(); | ||
| Some(text) | ||
| } |
crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
Comment on lines
210
to
235
| AnyJsExpression::AnyJsLiteralExpression(expr) => { | ||
| let expr = expr.as_js_string_literal_expression()?; | ||
| let text = expr.inner_string_text().ok()?; | ||
| Some(text.to_string()) | ||
| } | ||
| AnyJsExpression::JsTemplateExpression(expr) => { | ||
| let elements = expr.elements(); | ||
| if !elements | ||
| .iter() | ||
| .all(|elem| matches!(elem, AnyJsTemplateElement::JsTemplateChunkElement(_))) | ||
| { | ||
| return None; | ||
| } | ||
|
|
||
| let text = elements | ||
| .iter() | ||
| .filter_map(|elem| { | ||
| elem.as_js_template_chunk_element() | ||
| .unwrap() | ||
| .template_chunk_token() | ||
| .ok() | ||
| }) | ||
| .map(|elem| elem.text().replace('\n', "\\n")) | ||
| .collect::<String>(); | ||
|
|
||
| Some(text) |
There was a problem hiding this comment.
I refactored codes using it at e0ec310
Thank you for letting me know.
Comment on lines
208
to
209
| let expr = from.as_any_js_expression()?; | ||
| match expr.clone().omit_parentheses() { |
Conaclos
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement a useRegexLiterals lint rule.
fixes #353
Test Plan