Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update GitHub action #742

Merged
merged 2 commits into from
Nov 16, 2023
Merged

ci: update GitHub action #742

merged 2 commits into from
Nov 16, 2023

Conversation

Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Nov 16, 2023 •
edited
Loading

Summary

actions/checkout@v3 and actions/setup-node@v3 use Node v16 which is EOL since 11 Sep 2023, so bumped these to v4 that use Node v20.

Test Plan

  • Check if all CI tests pass

nhedger
nhedger approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@nhedger nhedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for your contribution @Gumichocopengin8 !

@ematipico ematipico merged commit 15c1a90 into biomejs:main Nov 16, 2023
2 checks passed
@Gumichocopengin8 Gumichocopengin8 deleted the ci/update-github-action branch November 16, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhedger nhedger nhedger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gumichocopengin8 @nhedger @ematipico