Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(biome_js_parser): report error when using u and v flag at the same time #631

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

This is a follow up PR of #619

Based on #619 (comment), I modified the parser to report an error when the u and v flags are used at the same time.
This PR is a follow up PR, so I don't update changelog.

Test Plan

I added some parser tests.

@nissy-dev nissy-dev temporarily deployed to Website deployment October 30, 2023 07:33 — with GitHub Actions Inactive
@nissy-dev nissy-dev changed the title fix: report error when using u and v flag at the same time fix(biome_js_parser): report error when using u and v flag at the same time Oct 30, 2023
@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48720 48721 ✅ ⏫ +1
Failed 981 980 ✅ ⏬ -1
Panics 0 0 0
Coverage 98.03% 98.03% +0.00%
🎉 Fixed (1):
built-ins/RegExp/prototype/unicodeSets/uv-flags.js

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

if flag.contains(RegexFlag::V) {
self.diagnostics.push(
ParseDiagnostic::new(
"invalid regex flag",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Invalid", capital letter. "flag.", with dot at the end

@Conaclos Conaclos added the A-Changelog Area: changelog label Oct 30, 2023
@nissy-dev nissy-dev temporarily deployed to Website deployment October 30, 2023 12:38 — with GitHub Actions Inactive
@github-actions github-actions bot removed the A-Changelog Area: changelog label Oct 30, 2023
@nissy-dev nissy-dev temporarily deployed to Website deployment October 30, 2023 13:10 — with GitHub Actions Inactive
@ematipico ematipico merged commit 2e3f703 into main Oct 30, 2023
16 checks passed
@ematipico ematipico deleted the support-v-flag branch October 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants