Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noRedeclare): don't report type params of method signatures #593

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 24, 2023

Summary

Fix #591.

The PR now create dedicated scope for method signatures. This is already done for function signatures and regular methods.

Test Plan

Regression tests added.

@Conaclos Conaclos temporarily deployed to Website deployment October 24, 2023 11:08 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 24, 2023
@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48642 48642 0
Failed 1059 1059 0
Panics 0 0 0
Coverage 97.87% 97.87% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@Conaclos Conaclos merged commit 00d8afe into main Oct 24, 2023
18 checks passed
@Conaclos Conaclos deleted the conaclos/lint/noRedeclare/591 branch October 24, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/suspicious/noRedeclare false positive
1 participant