fix(lint/noSelfAssign): don't panic #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-Linter
ematipico
reviewed
Oct 19, 2023
| @@ -713,7 +713,7 @@ impl TryFrom<(AnyNameLike, AnyNameLike)> for IdentifiersLike { | |||
| AnyNameLike::AnyJsLiteralExpression(right), | |||
| ) => Ok(Self::Literal(left, right)), | |||
|
|
|||
| _ => unreachable!("you should map the correct references"), | |||
| _ => Err(()), | |||
There was a problem hiding this comment.
the unreachable was there for a reason, which means we haven't mapped a specific type that we should
ematipico
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #548
Test Plan
regerssion test added.