biomejs · Conaclos · Oct 17, 2023 · Oct 17, 2023
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/biome_analyze/CONTRIBUTING.md b/crates/biome_analyze/CONTRIBUTING.md
@@ -305,8 +305,8 @@ The first step is to setup a struct to represent the rule configuration.
 ```rust,ignore
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ReactExtensiveDependenciesOptions {
-    hooks_config: HashMap<String, ReactHookConfiguration>,
-    stable_config: HashSet<StableReactHookConfiguration>,
+    hooks_config: FxHashMap<String, ReactHookConfiguration>,
+    stable_config: FxHashSet<StableReactHookConfiguration>,
 }
 
 impl Rule for UseExhaustiveDependencies {

diff --git a/crates/biome_analyze/src/options.rs b/crates/biome_analyze/src/options.rs
@@ -1,6 +1,7 @@
+use rustc_hash::FxHashMap;
+
 use crate::{Rule, RuleKey};
 use std::any::{Any, TypeId};
-use std::collections::HashMap;
 use std::fmt::Debug;
 use std::path::PathBuf;
 
@@ -28,7 +29,7 @@ impl RuleOptions {
 
 /// A convenient new type data structure to insert and get rules
 #[derive(Debug, Default)]
-pub struct AnalyzerRules(HashMap<RuleKey, RuleOptions>);
+pub struct AnalyzerRules(FxHashMap<RuleKey, RuleOptions>);
 
 impl AnalyzerRules {
     /// It tracks the options of a specific rule

diff --git a/crates/biome_analyze/src/services.rs b/crates/biome_analyze/src/services.rs
@@ -1,9 +1,7 @@
 use crate::{RuleKey, TextRange};
 use biome_diagnostics::{Diagnostic, LineIndexBuf, Resource, Result, SourceCode};
-use std::{
-    any::{Any, TypeId},
-    collections::HashMap,
-};
+use rustc_hash::FxHashMap;
+use std::any::{Any, TypeId};
 
 #[derive(Debug, Diagnostic)]
 #[diagnostic(category = "internalError/io", tags(INTERNAL))]
@@ -43,7 +41,7 @@ pub trait FromServices: Sized {
 
 #[derive(Debug, Default)]
 pub struct ServiceBag {
-    services: HashMap<TypeId, Box<dyn Any>>,
+    services: FxHashMap<TypeId, Box<dyn Any>>,
 }
 
 impl ServiceBag {

diff --git a/crates/biome_aria/Cargo.toml b/crates/biome_aria/Cargo.toml
@@ -14,3 +14,4 @@ version              = "0.1.0"
 
 [dependencies]
 biome_aria_metadata = { workspace = true }
+rustc-hash          = { workspace = true }
diff --git a/crates/biome_aria/src/roles.rs b/crates/biome_aria/src/roles.rs
@@ -1,6 +1,6 @@
 use crate::{define_role, is_aria_property_valid};
 use biome_aria_metadata::AriaPropertiesEnum;
-use std::collections::HashMap;
+use rustc_hash::FxHashMap;
 use std::fmt::Debug;
 use std::slice::Iter;
 use std::str::FromStr;
@@ -892,7 +892,7 @@ impl<'a> AriaRoles {
         &self,
         element: &str,
         // To generate `attributes`, you can use `biome_js_analyze::aria_services::AriaServices::extract_defined_attributes`
-        attributes: &HashMap<String, Vec<String>>,
+        attributes: &FxHashMap<String, Vec<String>>,
     ) -> Option<&'static dyn AriaRoleDefinition> {
         let result = match element {
             "article" => &ArticleRole as &dyn AriaRoleDefinition,
@@ -1023,7 +1023,7 @@ impl<'a> AriaRoles {
     pub fn is_not_interactive_element(
         &self,
         element_name: &str,
-        attributes: Option<HashMap<String, Vec<String>>>,
+        attributes: Option<FxHashMap<String, Vec<String>>>,
     ) -> bool {
         // <header> elements do not technically have semantics, unless the
         // element is a direct descendant of <body>, and this crate cannot
@@ -1125,7 +1125,7 @@ pub struct AriaRoles;
 
 #[cfg(test)]
 mod test {
-    use std::collections::HashMap;
+    use rustc_hash::FxHashMap;
 
     use crate::AriaRoles;
 
@@ -1134,7 +1134,7 @@ mod test {
         let aria_roles = AriaRoles {};
         assert!(!aria_roles.is_not_interactive_element("header", None));
         assert!(!aria_roles.is_not_interactive_element("input", {
-            let mut attributes = HashMap::new();
+            let mut attributes = FxHashMap::default();
             attributes.insert("type".to_string(), vec!["search".to_string()]);
             Some(attributes)
         }));
@@ -1151,7 +1151,7 @@ mod test {
         assert!(aria_roles.is_not_interactive_element("h6", None));
         assert!(aria_roles.is_not_interactive_element("body", None));
         assert!(aria_roles.is_not_interactive_element("input", {
-            let mut attributes = HashMap::new();
+            let mut attributes = FxHashMap::default();
             attributes.insert("type".to_string(), vec!["hidden".to_string()]);
             Some(attributes)
         }));
@@ -1163,12 +1163,12 @@ mod test {
 
         // No attributes
         let implicit_role = aria_roles
-            .get_implicit_role("button", &HashMap::new())
+            .get_implicit_role("button", &FxHashMap::default())
             .unwrap();
         assert_eq!(implicit_role.type_name(), "biome_aria::roles::ButtonRole");
 
         // <input type="search">
-        let mut attributes = HashMap::new();
+        let mut attributes = FxHashMap::default();
         attributes.insert("type".to_string(), vec!["search".to_string()]);
         let implicit_role = aria_roles.get_implicit_role("input", &attributes).unwrap();
         assert_eq!(
@@ -1177,7 +1177,7 @@ mod test {
         );
 
         // <select name="animals" multiple size="4">
-        let mut attributes = HashMap::new();
+        let mut attributes = FxHashMap::default();
         attributes.insert("name".to_string(), vec!["animals".to_string()]);
         attributes.insert("multiple".to_string(), vec![String::new()]);
         attributes.insert("size".to_string(), vec!["4".to_string()]);

diff --git a/crates/biome_cli/Cargo.toml b/crates/biome_cli/Cargo.toml
@@ -41,6 +41,7 @@ hdrhistogram         = { version = "7.5.0", default-features = false }
 indexmap             = { workspace = true }
 lazy_static          = { workspace = true }
 rayon                = "1.5.1"
+rustc-hash           = { workspace = true }
 serde                = { workspace = true, features = ["derive"] }
 serde_json           = { workspace = true }
 tokio                = { workspace = true, features = ["io-std", "io-util", "net", "time", "rt", "sync", "rt-multi-thread", "macros"] }

diff --git a/crates/biome_cli/src/execute/traverse.rs b/crates/biome_cli/src/execute/traverse.rs
@@ -24,7 +24,7 @@ use crossbeam::{
     channel::{unbounded, Receiver, Sender},
     select,
 };
-use std::collections::HashSet;
+use rustc_hash::FxHashSet;
 use std::{
     ffi::OsString,
     io,
@@ -297,7 +297,7 @@ fn process_messages(options: ProcessMessagesOptions) {
         warnings,
     } = options;
 
-    let mut paths: HashSet<String> = HashSet::new();
+    let mut paths: FxHashSet<String> = FxHashSet::default();
     let mut printed_diagnostics: u16 = 0;
     let mut not_printed_diagnostics = 0;
     let mut total_skipped_suggested_fixes = 0;

diff --git a/crates/biome_cli/src/metrics.rs b/crates/biome_cli/src/metrics.rs
@@ -1,13 +1,13 @@
 use std::{
     borrow::Cow,
-    collections::HashMap,
     hash::Hash,
     ops::Sub,
     ptr,
     time::{Duration, Instant},
 };
 
 use hdrhistogram::Histogram;
+use rustc_hash::FxHashMap;
 use std::sync::{Mutex, RwLock};
 use tracing::{span, subscriber::Interest, Level, Metadata, Subscriber};
 use tracing_subscriber::{
@@ -22,7 +22,7 @@ struct MetricsLayer;
 
 lazy_static::lazy_static! {
     /// Global storage for metrics data
-    static ref METRICS: RwLock<HashMap<CallsiteKey, Mutex<CallsiteEntry>>> = RwLock::default();
+    static ref METRICS: RwLock<FxHashMap<CallsiteKey, Mutex<CallsiteEntry>>> = RwLock::default();
 }
 
 /// Static pointer to the metadata of a callsite, used as a unique identifier

diff --git a/crates/biome_cli/src/reports/formatter.rs b/crates/biome_cli/src/reports/formatter.rs
@@ -1,5 +1,5 @@
+use rustc_hash::FxHashMap;
 use serde::Serialize;
-use std::collections::HashMap;
 
 #[derive(Debug, Default, Serialize)]
 #[serde(rename_all = "camelCase")]
@@ -8,7 +8,7 @@ pub struct FormatterReport {
     summary: Option<FormatterReportSummary>,
 
     /// The key is the path of the file
-    files: HashMap<String, FormatterReportFileDetail>,
+    files: FxHashMap<String, FormatterReportFileDetail>,
 }
 
 impl FormatterReport {

diff --git a/crates/biome_cli/src/reports/mod.rs b/crates/biome_cli/src/reports/mod.rs
@@ -4,8 +4,8 @@ use crate::reports::formatter::{FormatterReportFileDetail, FormatterReportSummar
 use biome_diagnostics::{Category, Severity};
 use biome_service::WorkspaceError;
 use formatter::FormatterReport;
+use rustc_hash::FxHashMap;
 use serde::Serialize;
-use std::collections::HashMap;
 
 #[derive(Debug, Default, Serialize)]
 pub struct Report {
@@ -15,7 +15,7 @@ pub struct Report {
     /// Diagnostics tracked during a generic traversal
     ///
     /// The key is the path of the file where the diagnostics occurred
-    diagnostics: HashMap<String, ReportErrorKind>,
+    diagnostics: FxHashMap<String, ReportErrorKind>,
 }
 
 #[derive(Debug, Serialize)]

diff --git a/crates/biome_control_flow/Cargo.toml b/crates/biome_control_flow/Cargo.toml
@@ -14,3 +14,4 @@ version              = "0.1.0"
 
 [dependencies]
 biome_rowan = { workspace = true }
+rustc-hash  = { workspace = true }
diff --git a/crates/biome_control_flow/src/lib.rs b/crates/biome_control_flow/src/lib.rs
@@ -1,11 +1,9 @@
 #![deny(rustdoc::broken_intra_doc_links)]
 
-use std::{
-    collections::HashMap,
-    fmt::{self, Display, Formatter},
-};
+use std::fmt::{self, Display, Formatter};
 
 use biome_rowan::{Language, SyntaxElement, SyntaxNode};
+use rustc_hash::FxHashMap;
 
 pub mod builder;
 
@@ -180,7 +178,7 @@ impl<L: Language> Display for ControlFlowGraph<L> {
     fn fmt(&self, fmt: &mut Formatter) -> fmt::Result {
         writeln!(fmt, "flowchart TB")?;
 
-        let mut links = HashMap::new();
+        let mut links = FxHashMap::default();
         for (id, block) in self.blocks.iter().enumerate() {
             if fmt.alternate() {
                 writeln!(fmt, "    subgraph block_{id}")?;

diff --git a/crates/biome_formatter/src/format_element/document.rs b/crates/biome_formatter/src/format_element/document.rs
@@ -10,7 +10,6 @@ use crate::{
 };
 use biome_rowan::TextSize;
 use rustc_hash::FxHashMap;
-use std::collections::HashMap;
 use std::ops::Deref;
 
 /// A formatted document.
@@ -133,7 +132,7 @@ impl std::fmt::Display for Document {
 #[derive(Clone, Default, Debug)]
 struct IrFormatContext {
     /// The interned elements that have been printed to this point
-    printed_interned_elements: HashMap<Interned, usize>,
+    printed_interned_elements: FxHashMap<Interned, usize>,
 }
 
 impl FormatContext for IrFormatContext {

diff --git a/crates/biome_fs/Cargo.toml b/crates/biome_fs/Cargo.toml
@@ -19,6 +19,7 @@ crossbeam         = "0.8.2"
 indexmap          = { workspace = true }
 parking_lot       = { version = "0.12.0", features = ["arc_lock"] }
 rayon             = "1.7.0"
+rustc-hash        = { workspace = true }
 schemars          = { workspace = true, optional = true }
 serde             = { workspace = true }
 tracing           = { workspace = true }

diff --git a/crates/biome_fs/src/fs/memory.rs b/crates/biome_fs/src/fs/memory.rs
@@ -1,5 +1,5 @@
-use std::collections::hash_map::Entry;
-use std::collections::{hash_map::IntoIter, HashMap};
+use rustc_hash::FxHashMap;
+use std::collections::hash_map::{Entry, IntoIter};
 use std::io;
 use std::panic::AssertUnwindSafe;
 use std::path::{Path, PathBuf};
@@ -16,8 +16,8 @@ use super::{BoxedTraversal, ErrorKind, File, FileSystemDiagnostic};
 
 /// Fully in-memory file system, stores the content of all known files in a hashmap
 pub struct MemoryFileSystem {
-    files: AssertUnwindSafe<RwLock<HashMap<PathBuf, FileEntry>>>,
-    errors: HashMap<PathBuf, ErrorEntry>,
+    files: AssertUnwindSafe<RwLock<FxHashMap<PathBuf, FileEntry>>>,
+    errors: FxHashMap<PathBuf, ErrorEntry>,
     allow_write: bool,
 }
 

diff --git a/crates/biome_js_analyze/src/analyzers/correctness/no_nonoctal_decimal_escape.rs b/crates/biome_js_analyze/src/analyzers/correctness/no_nonoctal_decimal_escape.rs
@@ -7,7 +7,8 @@ use biome_diagnostics::Applicability;
 use biome_js_factory::make;
 use biome_js_syntax::JsStringLiteralExpression;
 use biome_rowan::{AstNode, BatchMutationExt, TextRange};
-use std::{collections::HashSet, ops::Range};
+use rustc_hash::FxHashSet;
+use std::ops::Range;
 
 declare_rule! {
     /// Disallow `\8` and `\9` escape sequences in string literals.
@@ -166,7 +167,7 @@ impl Rule for NoNonoctalDecimalEscape {
             }
         }
 
-        let mut seen = HashSet::new();
+        let mut seen = FxHashSet::default();
         signals.retain(|rule_state| seen.insert(rule_state.diagnostics_text_range));
         signals
     }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,3 +14,4 @@ version = "0.1.0"

		[dependencies]
		biome_aria_metadata = { workspace = true }
		rustc-hash = { workspace = true }