chore: promote rules

[ematipico]

Summary

Closes #410

Test Plan

CI should pass

[github-actions]

Parser conformance results on

js/262

Test result	main count	This PR count	Difference
Total	49701	49701	0
Passed	48642	48642	0
Failed	1059	1059	0
Panics	0	0	0
Coverage	97.87%	97.87%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6322	6322	0
Passed	2036	2036	0
Failed	4286	4286	0
Panics	0	0	0
Coverage	32.20%	32.20%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	662	662	0
Passed	592	592	0
Failed	70	70	0
Panics	0	0	0
Coverage	89.43%	89.43%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17646	17646	0
Passed	13454	13454	0
Failed	4190	4190	0
Panics	2	2	0
Coverage	76.24%	76.24%	0.00%

[Conaclos]

Looks good!

I think you forgot to promote noGlobalIsFinite to suspicious.

I could also rename noExcessiveComplexity to noExcessiveCognitiveComplexity.

Also we could promote and recommend noDuplicatePrivateClassMembers and noSuperWithoutExtends syntax rules?

[ematipico]

Also we could promote and recommend noDuplicatePrivateClassMembers and noSuperWithoutExtends syntax rules?

These aren't lint rules, they are syntax rules. Users aren't able to configure them. They always run because they are meant to catch syntax errors or runtime errors.

[Conaclos]

These aren't lint rules, they are syntax rules. Users aren't able to configure them. They always run because they are meant to catch syntax errors or runtime errors.

Is it normal the recommend flag is set to false and they are placed in a nursery folder?

[ematipico]

Is it normal the recommend flag is set to false and they are placed in a nursery folder?

No, it seems that the script didn't work. Let me fix that, good catch

[Conaclos]

I think you forgot to promote noGlobalIsFinite to suspicious.

I could also rename noExcessiveComplexity to noExcessiveCognitiveComplexity.

Also, a changelog entry is missing :)

[ematipico]

Also, a changelog entry is missing :)

Any suggestion/help? I don't know what's the expected changelog line

[Conaclos]

Any suggestion/help? I don't know what's the expected changelog line

We could use the same template that the previous version, creating a Promoted rules section.

[ematipico]

Done!