fix(project): change how extends
should be applied
#516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #343
When I implemented the feature, I implemented it with an incorrect assumption, where
extends
would override the current configuration.Instead,
extends
should be computed first, and then on top of the result, we should apply the options ofbiome.json
file.To achieve this, I had to create a new method called
merge_if_not_default
. This was needed to avoid default values overriding what was computed from theextends
.Test Plan
I added a new test case, similar to the one of the issue that is closed. The snapshot shows that Biome format the code that correct options.