Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Rust to 1.73.0 #508

Merged
merged 1 commit into from
Oct 10, 2023
Merged

chore: upgrade Rust to 1.73.0 #508

merged 1 commit into from
Oct 10, 2023

Conversation

ematipico
Copy link
Member

Summary

According to the title.

Test Plan

The current CI should pass.

@ematipico ematipico temporarily deployed to Website deployment October 10, 2023 09:57 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages labels Oct 10, 2023
@ematipico
Copy link
Member Author

!bench_formatter
!bench_parser
!bench_analyzer

@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47808 47808 0
Failed 1055 1055 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 2030 2030 0
Failed 4182 4182 0
Panics 0 0 0
Coverage 32.68% 32.68% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 571 571 0
Failed 68 68 0
Panics 0 0 0
Coverage 89.36% 89.36% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13123 13123 0
Failed 4101 4101 0
Panics 0 0 0
Coverage 76.19% 76.19% 0.00%

@github-actions
Copy link
Contributor

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.01      5.1±0.07ms     2.3 MB/sec    1.00      5.0±0.11ms     2.4 MB/sec
analyzer/index.js         1.00     10.5±0.18ms     2.9 MB/sec    1.01     10.6±0.38ms     2.9 MB/sec
analyzer/lint.ts          1.00      7.8±0.16ms     5.3 MB/sec    1.03      8.1±0.11ms     5.1 MB/sec
analyzer/parser.ts        1.00     15.4±0.28ms     3.2 MB/sec    1.01     15.5±0.30ms     3.1 MB/sec
analyzer/router.ts        1.00      4.9±0.08ms     4.8 MB/sec    1.00      4.9±0.09ms     4.8 MB/sec
analyzer/statement.ts     1.00     14.5±0.28ms     2.4 MB/sec    1.01     14.6±0.22ms     2.4 MB/sec
analyzer/typescript.ts    1.00     23.2±0.51ms     2.4 MB/sec    1.01     23.4±0.46ms     2.3 MB/sec

@github-actions
Copy link
Contributor

Formatter Benchmark Results

group                                    main                                   pr
-----                                    ----                                   --
formatter/big5-added.json                1.00    484.7±0.30µs    34.9 MB/sec    1.06    512.1±0.45µs    33.0 MB/sec
formatter/canada.json                    1.00    226.4±2.96ms     9.5 MB/sec    1.08    243.7±2.96ms     8.8 MB/sec
formatter/checker.ts                     1.03    385.3±3.05ms     6.7 MB/sec    1.00    374.1±2.73ms     6.9 MB/sec
formatter/compiler.js                    1.04    213.5±2.00ms     4.9 MB/sec    1.00    206.2±1.96ms     5.1 MB/sec
formatter/d3.min.js                      1.02    164.2±2.66ms  1634.4 KB/sec    1.00    160.7±2.78ms  1670.4 KB/sec
formatter/db.json                        1.00     13.6±0.06ms    13.4 MB/sec    1.06     14.5±0.09ms    12.6 MB/sec
formatter/dojo.js                        1.02     10.8±0.04ms     6.4 MB/sec    1.00     10.6±0.06ms     6.5 MB/sec
formatter/eucjp.json                     1.00    834.1±0.43µs    47.0 MB/sec    1.05    878.8±0.76µs    44.6 MB/sec
formatter/ios.d.ts                       1.01    241.0±1.69ms     7.7 MB/sec    1.00    238.0±1.73ms     7.8 MB/sec
formatter/jquery.min.js                  1.02     44.0±0.44ms  1925.0 KB/sec    1.00     42.9±0.37ms  1970.8 KB/sec
formatter/math.js                        1.04    327.8±3.27ms  2023.0 KB/sec    1.00    316.4±1.78ms     2.0 MB/sec
formatter/package-lock.json              1.00      5.9±0.02ms    23.2 MB/sec    1.05      6.2±0.01ms    22.1 MB/sec
formatter/parser.ts                      1.02      7.4±0.02ms     6.6 MB/sec    1.00      7.3±0.05ms     6.7 MB/sec
formatter/pixi.min.js                    1.02    177.6±2.35ms     2.5 MB/sec    1.00    174.3±2.10ms     2.5 MB/sec
formatter/react-dom.production.min.js    1.03     51.5±0.93ms     2.2 MB/sec    1.00     50.0±0.76ms     2.3 MB/sec
formatter/react.production.min.js        1.02      2.5±0.01ms     2.4 MB/sec    1.00      2.5±0.01ms     2.5 MB/sec
formatter/router.ts                      1.02      2.6±0.00ms     9.0 MB/sec    1.00      2.6±0.01ms     9.1 MB/sec
formatter/tex-chtml-full.js              1.03    421.6±2.76ms     2.2 MB/sec    1.00    408.8±2.51ms     2.2 MB/sec
formatter/three.min.js                   1.03    216.6±2.23ms     2.7 MB/sec    1.00    210.6±1.72ms     2.8 MB/sec
formatter/typescript.js                  1.04   1462.5±7.55ms     6.5 MB/sec    1.00   1403.7±6.30ms     6.8 MB/sec
formatter/vue.global.prod.js             1.03     68.4±1.28ms  1803.6 KB/sec    1.00     66.6±1.12ms  1853.8 KB/sec

@github-actions
Copy link
Contributor

Parser Benchmark Results

group                                          main                                   pr
-----                                          ----                                   --
parser/big5-added.json/cached                  1.00    147.3±2.09µs   114.7 MB/sec    1.00    147.4±1.91µs   114.6 MB/sec
parser/big5-added.json/uncached                1.03    179.9±0.44µs    93.9 MB/sec    1.00    175.3±0.28µs    96.4 MB/sec
parser/canada.json/cached                      1.00     85.6±2.95ms    25.1 MB/sec    1.01     86.6±3.60ms    24.8 MB/sec
parser/canada.json/uncached                    1.01     93.0±2.43ms    23.1 MB/sec    1.00     91.8±2.46ms    23.4 MB/sec
parser/checker.ts/cached                       1.01    113.9±1.39ms    22.8 MB/sec    1.00    112.6±1.51ms    23.1 MB/sec
parser/checker.ts/uncached                     1.00    120.8±1.97ms    21.5 MB/sec    1.00    121.1±1.43ms    21.5 MB/sec
parser/compiler.js/cached                      1.01     66.5±0.87ms    15.8 MB/sec    1.00     65.6±1.27ms    16.0 MB/sec
parser/compiler.js/uncached                    1.03     70.6±0.95ms    14.8 MB/sec    1.00     68.6±0.77ms    15.3 MB/sec
parser/d3.min.js/cached                        1.02     41.6±0.51ms     6.3 MB/sec    1.00     40.9±0.59ms     6.4 MB/sec
parser/d3.min.js/uncached                      1.01     42.6±0.51ms     6.2 MB/sec    1.00     42.0±0.46ms     6.2 MB/sec
parser/db.json/cached                          1.01      4.1±0.03ms    44.1 MB/sec    1.00      4.1±0.02ms    44.4 MB/sec
parser/db.json/uncached                        1.03      4.8±0.02ms    38.3 MB/sec    1.00      4.6±0.03ms    39.4 MB/sec
parser/dojo.js/cached                          1.01      3.2±0.01ms    21.2 MB/sec    1.00      3.2±0.01ms    21.4 MB/sec
parser/dojo.js/uncached                        1.01      3.7±0.01ms    18.3 MB/sec    1.00      3.7±0.01ms    18.6 MB/sec
parser/eucjp.json/cached                       1.00    270.0±3.82µs   145.0 MB/sec    1.01    273.5±3.44µs   143.2 MB/sec
parser/eucjp.json/uncached                     1.01    310.1±1.26µs   126.3 MB/sec    1.00    308.1±2.18µs   127.1 MB/sec
parser/ios.d.ts/cached                         1.01     98.9±0.93ms    18.9 MB/sec    1.00     97.8±1.82ms    19.1 MB/sec
parser/ios.d.ts/uncached                       1.01    101.4±1.34ms    18.4 MB/sec    1.00    100.5±1.36ms    18.6 MB/sec
parser/jquery.min.js/cached                    1.01     10.5±0.03ms     7.9 MB/sec    1.00     10.4±0.05ms     8.0 MB/sec
parser/jquery.min.js/uncached                  1.02     11.3±0.05ms     7.3 MB/sec    1.00     11.1±0.04ms     7.5 MB/sec
parser/math.js/cached                          1.02     80.2±0.76ms     8.1 MB/sec    1.00     78.8±1.00ms     8.2 MB/sec
parser/math.js/uncached                        1.01     82.2±0.81ms     7.9 MB/sec    1.00     81.1±0.70ms     8.0 MB/sec
parser/package-lock.json/cached                1.00   1752.3±9.79µs    78.7 MB/sec    1.00  1751.4±23.45µs    78.7 MB/sec
parser/package-lock.json/uncached              1.01   1941.2±8.11µs    71.0 MB/sec    1.00  1924.0±17.52µs    71.6 MB/sec
parser/parser.ts/cached                        1.01      2.4±0.04ms    20.7 MB/sec    1.00      2.3±0.01ms    20.9 MB/sec
parser/parser.ts/uncached                      1.01      2.7±0.01ms    18.2 MB/sec    1.00      2.7±0.03ms    18.4 MB/sec
parser/pixi.min.js/cached                      1.04     51.1±1.00ms     8.6 MB/sec    1.00     49.1±0.76ms     8.9 MB/sec
parser/pixi.min.js/uncached                    1.03     53.2±1.00ms     8.3 MB/sec    1.00     51.8±0.86ms     8.5 MB/sec
parser/react-dom.production.min.js/cached      1.02     14.1±0.14ms     8.2 MB/sec    1.00     13.9±0.13ms     8.3 MB/sec
parser/react-dom.production.min.js/uncached    1.02     15.3±0.08ms     7.5 MB/sec    1.00     15.0±0.08ms     7.7 MB/sec
parser/react.production.min.js/cached          1.02    662.1±2.31µs     9.3 MB/sec    1.00    648.4±7.15µs     9.5 MB/sec
parser/react.production.min.js/uncached        1.02    749.3±1.57µs     8.2 MB/sec    1.00    735.2±3.54µs     8.4 MB/sec
parser/router.ts/cached                        1.01    775.5±5.17µs    30.3 MB/sec    1.00    770.6±4.86µs    30.5 MB/sec
parser/router.ts/uncached                      1.02    933.4±3.34µs    25.1 MB/sec    1.00    915.8±3.14µs    25.6 MB/sec
parser/tex-chtml-full.js/cached                1.02    109.6±1.54ms     8.3 MB/sec    1.00    107.9±1.46ms     8.4 MB/sec
parser/tex-chtml-full.js/uncached              1.02    112.5±1.52ms     8.1 MB/sec    1.00    110.2±1.43ms     8.3 MB/sec
parser/three.min.js/cached                     1.05     58.2±0.64ms    10.1 MB/sec    1.00     55.5±0.59ms    10.6 MB/sec
parser/three.min.js/uncached                   1.04     59.5±0.50ms     9.9 MB/sec    1.00     57.1±0.66ms    10.3 MB/sec
parser/typescript.js/cached                    1.01    447.4±6.14ms    21.2 MB/sec    1.00    444.0±4.75ms    21.4 MB/sec
parser/typescript.js/uncached                  1.01    468.9±4.55ms    20.3 MB/sec    1.00    463.9±4.00ms    20.5 MB/sec
parser/vue.global.prod.js/cached               1.01     17.5±0.18ms     6.9 MB/sec    1.00     17.4±0.22ms     6.9 MB/sec
parser/vue.global.prod.js/uncached             1.01     18.6±0.12ms     6.5 MB/sec    1.00     18.3±0.13ms     6.6 MB/sec

@ematipico ematipico merged commit c017179 into main Oct 10, 2023
@ematipico ematipico deleted the chore/upgrade-rust branch October 10, 2023 10:40
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants