Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(noRestrictedImports): update version notice #4758

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

MaxtuneLee
Copy link
Contributor

Summary

Changed the version number from v1.6.0 to v2.0.0 to reflect the correct introduction version of the no-restricted-imports rule.

Issue mentioned in #4750

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Dec 19, 2024
dyc3
dyc3 previously requested changes Dec 19, 2024
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. The options have changed in 2.0. The rule has been there since 1.6.0.

@MaxtuneLee
Copy link
Contributor Author

This doesn't look right. The options have changed in 2.0. The rule has been there since 1.6.0.

Thank you for the review. I reviewed this pull request and am wondering how users can access configuration documentation for previous versions. Do we need to retain the old docs here, considering that v2 hasn't been released yet?

@dyc3
Copy link
Contributor

dyc3 commented Dec 19, 2024

Yes, we should probably retain the old docs. Go ahead and add them alongside the new docs here in the rule, and make sure to label it with the version it applies to.

@MaxtuneLee MaxtuneLee requested a review from dyc3 December 20, 2024 02:52
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico dismissed dyc3’s stale review December 20, 2024 16:20

Feedback addressed

@ematipico ematipico merged commit 09a04af into biomejs:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants