-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formatter/member-chain): regex formatting #474
fix(formatter/member-chain): regex formatting #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just left a minor comment. Feel free to merge the PR once addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some research in prettier repo, I discovered that regex expressions should only be considered simple if they have a length less than or equal to 5
:o this seems so strange as behavior!
Good work, everything looks great :)
That's prettier for you :) |
Summary
This PR fixes #300
About the resolution
After some research in prettier repo, I discovered that regex expressions should only be considered
simple
if they have a length less than or equal to 5Prettier ref: https://github.com/prettier/prettier/blob/d4d4b185e0ddc3e0dd839b873e2ee7fe8131b684/src/language-js/utils/index.js#L761C1-L761C1
Test Plan