feat(format/html): opt out of formatting for pre, script and style tags
#4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Dec 12, 2024
CodSpeed Performance ReportMerging #4729 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
09-18-feat_format_html_opt_out_of_formatting_for_script_and_style_tags
branch
from
68d784a to
f7e3116
Compare
dyc3
deleted the
09-18-feat_format_html_opt_out_of_formatting_for_script_and_style_tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes it so
pre,script, andstyletags are not formatted.The
pretag is for "preformatted text": https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre . I went ahead and also excluded script and style tags too since we don't have embedded formatting, and the current formatting completely mangles and unformats js and css in those tags.closes #4021
Test Plan
Added a snapshot test, and ran it against prettier tests.