chore: update CONTRIBUTING.md #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
nissy-dev
commented
Oct 2, 2023
| @@ -229,41 +283,6 @@ pnpm install | |||
| pnpm start | |||
| ``` | |||
|
|
|||
| ### Generated files | |||
There was a problem hiding this comment.
move to crate development section
nissy-dev
commented
Oct 2, 2023
| ### Versioning | ||
|
|
||
| We follow the specs suggested by [the official documentation](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions): | ||
|
|
||
| Odd minor versions are dedicated to pre-releases, e.g. `*.5.*` . | ||
| Even minor versions are dedicated to official releases, e.g. `*.6.*`. | ||
|
|
||
| ### Playground |
nissy-dev
commented
Oct 2, 2023
Comment on lines
-376
to
-382
| ### Analyzers and lint rules | ||
|
|
||
| To know the technical details of how our analyzer works, how to create a rule and how to write tests, please check our [contribution page](https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md) | ||
|
|
||
| ### Formatter | ||
|
|
||
| To know the technical details of how our formatter works and how to write test, please check our [contribution page](https://github.com/biomejs/biome/blob/main/crates/biome_js_formatter/CONTRIBUTING.md) |
There was a problem hiding this comment.
move to crates development section
ematipico
approved these changes
Oct 3, 2023
CONTRIBUTING.md
Outdated
Comment on lines
136
to
138
| This command will create new tests for your parser. We currently have a neat infrastructure | ||
| where tests for parser are generated com inline comments found inside | ||
| the source code. |
There was a problem hiding this comment.
We are moving away from this approach. While the JS and JSON parsers still use this infra, the CSS parser now uses a more straightforward process. Maybe we should rephrase this paragraph to communicate this to the contributors.
Co-authored-by: Emanuele Stoppa <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Co-authored-by: Emanuele Stoppa <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Co-authored-by: Emanuele Stoppa <[email protected]>
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
nissy-dev
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
|
Thank you for reviews! I updated based on your comments. |
ematipico
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update CONTRIBUTING.md
Test Plan