feat(linter): add NoUnknownAtRule #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33b16a6.
github-actions
bot
added
A-Project
togami2864
commented
Dec 3, 2024
Comment on lines
+107
to
+111
| /* TODO: the parser not supported yet */ | ||
| /* @position-try --foo {} | ||
| @view-transition { | ||
| navigation: auto; | ||
| } */ |
There was a problem hiding this comment.
filed as an issue #4685
ematipico
reviewed
Dec 3, 2024
Comment on lines
76
to
78
| fn diagnostic(_: &RuleContext<Self>, node: &Self::State) -> Option<RuleDiagnostic> { | ||
| let span = node.range; | ||
| let name = &node.name; |
There was a problem hiding this comment.
Suggested change
| fn diagnostic(_: &RuleContext<Self>, node: &Self::State) -> Option<RuleDiagnostic> { | |
| let span = node.range; | |
| let name = &node.name; | |
| fn diagnostic(_: &RuleContext<Self>, state: &Self::State) -> Option<RuleDiagnostic> { | |
| let span = state.range; | |
| let name = &state.name; |
Comment on lines
87
to
91
| .note(markup! { | ||
| ""<Emphasis>{ name }</Emphasis>" is not a standard CSS at-rule, which may lead to unexpected styling results or failure to interpret the styles as intended." | ||
| }).note(markup! { | ||
| "See "<Hyperlink href="https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule">"MDN web docs"</Hyperlink>" for more details." | ||
| }), |
There was a problem hiding this comment.
At the end, we need to suggest a solution to the user (see the three rule pillars). In this case, we should suggest to remove it. (another alternative is to list all the known rules, but I think it's too much)
CodSpeed Performance ReportMerging #4689 will improve performances by 6.79%Comparing Summary
Benchmarks breakdown
|
ematipico
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #4688
Test Plan
added tests and updated snapshots