refactor: cleaned up workspaceError enum in biome_service/diagnostics.rs

[sikehish]

Summary

closes #4668

I have removed the following unused variants from the WorkspaceError enum:

• ReportNotSerializable
• DirtyWorkspace
• CantReadDirectory

The motivation behind these changes is to eliminate unused code, thereby reducing bloat and improving maintainability.

[dyc3]

Looks good! Less code is always better.

FYI, GitHub only properly links the issue if you put "fixes #x" or "closes #x" in the PR description.

[ematipico]

You forgot to remove the directives

[sikehish]

Hi @ematipico . Appolgize for it; missed it due to oversight. I've made the change.

[sikehish]

Looks good! Less code is always better.

FYI, GitHub only properly links the issue if you put "fixes #x" or "closes #x" in the PR description.

I've tagged the issue in the PR description. Do I need to reword it?

[ematipico]

@sikehish yes, using the words "closes #xxx" or "fixes #xxx`, GitHub will automatically close the issue once the PR is merged

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

[sikehish]

@sikehish yes, using the words "closes #xxx" or "fixes #xxx`, GitHub will automatically close the issue once the PR is merged

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

Thanks for the information! I've updated the PR message. I've also made the change, let me know if anything else needs to be changed :)

[ematipico]

The CI is failing. You need to format the project. Use just format

[sikehish]

The CI is failing. You need to format the project. Use just format

Yup, completely forgot to format. Anything else that needs to be done?