Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_parser): don't panic on declare@ #4601

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

fireairforce
Copy link
Member

Summary

closes: #4562

Now it will panic on:

declare@

so i replace .expect() with .add_diagnostic() at parse_declare.

Test Plan

I add test case for this.

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 20, 2024
@fireairforce fireairforce force-pushed the fix-4562 branch 2 times, most recently from 1f11ea2 to 3c71d72 Compare November 20, 2024 06:05
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #4601 will improve performances by 6.09%

Comparing fireairforce:fix-4562 (77663bb) with main (486ec39)

Summary

⚡ 1 improvements
✅ 98 untouched benchmarks

Benchmarks breakdown

Benchmark main fireairforce:fix-4562 Change
pure_9395922602181450299.css[uncached] 4.3 ms 4.1 ms +6.09%

Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳🥳🥳

@ematipico ematipico merged commit c0cccb2 into biomejs:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Crash Expected a declaration as guaranteed by is_at_ts_declare_statement when linting
3 participants