fix(css): reformat issue in comments between compound selectors #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
commented
Nov 14, 2024
There was a problem hiding this comment.
I gave up checking regressions with Prettier tests, because many of them include unsupported syntax, so we have parsing errors. At the end, they aren't reliable
ematipico
force-pushed
the
fix/reformat-issue-css
branch
from
be7caa3 to
7089b10
Compare
CodSpeed Performance ReportMerging #4537 will not alter performanceComparing Summary
|
Conaclos
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3229
The issue was caused by comments that belonged to
leftandcombinatorof aCssCompoundSelector.To make the reformatting happy, I decided to place the comments of the node to be a trailing comment of
right.The end result is way better than Prettier. Prettier isn't able to remove the empty lines inside comments, while Biome can, as shown in the test snapshot.
Test Plan
Added few test cases similar to the one reported (and the one reported)