refactor(js_syntax): minor clean up #4513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SyntaxResult
instead ofOption
where possible.Option<X>
instead ofSyntaxResult<Option<X>>
split_ascii_whitespace
instead ofsplit_whitespace
for splitting HTML attribute values.TokenString
instead ofString
forget_attribute_inner_string_text
.Test Plan
CI must pass.