refactor(aria): move properties to aria-metdata #4481
Conversation
github-actions
bot
added
A-Linter
| let default_value = data | ||
| .values | ||
| .iter() | ||
| .find(|(_, data)| data.is_default) | ||
| .map(|(name, _)| name); | ||
| let other_values = data | ||
| .values | ||
| .iter() | ||
| .filter(|(_, data)| !data.is_default) | ||
| .map(|(name, _)| name); | ||
| let values = default_value.into_iter().chain(other_values); |
There was a problem hiding this comment.
This part is responsible for the reordering of values in the snapshots.
Conaclos
force-pushed
the
conaclos/biome-aria-metdata-aria-attributes
branch
from
ea077f7 to
383a0cd
Compare
|
We should write somewhere instructions on how to update these data. I know we have a scraper, did we write somewhere how to use it? |
CodSpeed Performance ReportMerging #4481 will not alter performanceComparing Summary
|
I previously introduced |
I think it's enough. Thank you! |
Summary
Part of #4241.
This PR moves aria properties from
biome-ariatobiome-aria-metadata.I renamed
AriaPropertiesEnumtoAriaAttributebecause aria properties includes both aria properties and aria states.This is also the name used by MDN.
I also renamed
AriaPropertyTypetoAriaValueTypeand added the tokens directly in theTokenandTokenListvariants.I didn't see the utility of declaring a service for retrieving the Aria attributes. So, I removed the service.
This allows to use the
Astquery instead of theAriaquery in some rules.Once #4241 completed, we will certainly get rid of the
Ariaquery.Also, we should certainly merge the
biome-ariaandbiome-aria-metadatacrates.Test Plan
O updated the snapshots.
The only side effect of the change is some reordering of tokens: I placed the default token first.