refactor(noUnusedImports): report empty named imports #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
ematipico
approved these changes
Nov 6, 2024
crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/invalid-unused-react.jsx.snap
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| source: crates/biome_js_analyze/tests/spec_tests.rs | |||
| expression: invalid-import-namespace.ts | |||
| snapshot_kind: text | |||
There was a problem hiding this comment.
Is this new? Which version of cargo-insta are you using?
There was a problem hiding this comment.
The latest one: cargo-insta 1.41.1
CodSpeed Performance ReportMerging #4478 will improve performances by 6.9%Comparing Summary
Benchmarks breakdown
|
Conaclos
force-pushed
the
conaclos/noUnusedImports-empty-imports
branch
from
10c3031 to
bb8e14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3574 and #4240
Test Plan
I added a test and updated the snapshots.