Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove JS parser test generation codegen #4443

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Conaclos
Copy link
Member

Summary

We recently replaced the inline tests with proper insta tests in #4386.
The codegen that generates test data from the inline tests was not removed.
This PR removes this codegen.

Test Plan

CI must pass.

@Conaclos Conaclos requested a review from ematipico October 31, 2024 15:04
@github-actions github-actions bot added the A-Tooling Area: internal tools label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48537 48537 0
Passed 47345 47345 0
Failed 1192 1192 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6580 6580 0
Passed 2205 2205 0
Failed 4375 4375 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 607 607 0
Failed 73 73 0
Panics 0 0 0
Coverage 89.26% 89.26% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18568 18568 0
Passed 14228 14228 0
Failed 4340 4340 0
Panics 0 0 0
Coverage 76.63% 76.63% 0.00%

@Conaclos Conaclos force-pushed the conaclos/remove-parser-test-generation-script branch from 04658a8 to b539fa0 Compare October 31, 2024 15:16
Copy link

codspeed-hq bot commented Oct 31, 2024

CodSpeed Performance Report

Merging #4443 will not alter performance

Comparing conaclos/remove-parser-test-generation-script (ae46989) with main (9089e7d)

Summary

✅ 99 untouched benchmarks

@ematipico ematipico merged commit ec46f37 into main Nov 1, 2024
13 checks passed
@ematipico ematipico deleted the conaclos/remove-parser-test-generation-script branch November 1, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants