chore: publish some crates and add add workflow for publish crates #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
nissy-dev
commented
Sep 28, 2023
nissy-dev
commented
Sep 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
nissy-dev
commented
Sep 28, 2023
| @@ -22,11 +21,11 @@ biome_rowan = { workspace = true } | |||
| tracing = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| biome_test_utils = { workspace = true } | |||
| biome_test_utils = { path = "../biome_test_utils" } | |||
There was a problem hiding this comment.
Use the path dependency to avoid requiring these crates to be published when doing cargo publish
nissy-dev
commented
Sep 28, 2023
| @@ -83,7 +83,7 @@ quickcheck_macros = "1.0.0" | |||
| quote = { version = "1.0.28" } | |||
| rustc-hash = "1.1.0" | |||
| schemars = { version = "0.8.12" } | |||
| serde = { version = "1.0.163", features = ["derive"], default-features = false } | |||
There was a problem hiding this comment.
This change is necessary to avioid build errors about some crates
ematipico
approved these changes
Oct 2, 2023
|
Thanks! I'm going to edit contributing.md a bit after merging this, and I'll see if I can also add what you pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #190
I publish some crates and add add workflow for publish crates
see: https://crates.io/search?q=biome_
I invited @ematipico to each crates owner.
Test Plan
All tests should be passed