Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(useImportType,useExportType): ignore dts #4418

Merged
merged 1 commit into from
Oct 29, 2024
Merged

refactor(useImportType,useExportType): ignore dts #4418

merged 1 commit into from
Oct 29, 2024
+6 −2

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 29, 2024 •
edited
Loading

Summary

Fix #4417

Test Plan

Unfortunately we cannot test declaration files yet.
I didn't manage to extend our test infra to support it.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 29, 2024
@Conaclos Conaclos merged commit d780164 into main Oct 29, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/useImportExportType-ignore-dts branch October 29, 2024 10:42
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #4418 will not alter performance

Comparing conaclos/useImportExportType-ignore-dts (39afbe3) with main (3530f2f)

Summary

✅ 99 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💅 useImportType reports issues in definition files
1 participant
@Conaclos