-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css_formatter): don't indent CSS selector when leading comments before #4392
Conversation
248e734
to
a5739ec
Compare
df75efb
to
98a4175
Compare
CodSpeed Performance ReportMerging #4392 will not alter performanceComparing Summary
|
CHANGELOG.md
Outdated
@@ -28,6 +28,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b | |||
|
|||
### Formatter | |||
|
|||
### Bug fixes | |||
|
|||
- Fix [#4121](https://github.com/biomejs/biome/issues/4326), don't ident css selector when comments before. Contributed by @fireairforce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix [#4121](https://github.com/biomejs/biome/issues/4326), don't ident css selector when comments before. Contributed by @fireairforce | |
- Fix [#4121](https://github.com/biomejs/biome/issues/4326), don't ident CSS selector when comments before. Contributed by @fireairforce |
You need to add something after the word "before" because, as is, it's incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done~ updated the changelog
crates/biome_css_formatter/src/css/lists/relative_selector_list.rs
Outdated
Show resolved
Hide resolved
4bf2149
to
307a50a
Compare
307a50a
to
96c78b2
Compare
Summary
closes: #4326
I add special judge for that case:
If i get a
CSS_Type_Selector
like:/* hi */\n a,\n div
(you can refer this from above case), i will not add an ident for this to avoid this case, the previous logic atbiome_css_formatter
will add an ident for this case by default.Test Plan
add test case like:
my fix as follows: