refactor(ast): remove JsImportNamespaceClause #431
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was working on #428, I noticed that a namespace import, such as
import * as X from ""
, can be represented in two ways. One way usesJsImportNamesapceClause
and the other useJsNamespaceImportSpecifier
embedded inside aJsNamedImportClause
with a missingJsDefaultImportSpecifier
.This PR removes
JsImportNamespaceClause
and ensure that we have a unique way of representing a namespace import.I think we should refactor the import AST nodes further. There is room for better factorization.
Test Plan
Updated snapshots.