Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noInteractiveElementToNoninteractiveRole): fix <source /> error case #4300

Conversation

eryue0220
Copy link
Contributor

Summary

Close: #4228

Test Plan

Test case added:

<picture>
  <source
    srcSet={'/assets/head.webp'}
    role='img'
    type='image/webp'
  />
  <img
    src={'/assets/head.png'}
    alt='An ASCII-style headshot'
  />
</picture>

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 15, 2024
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #4300 will improve performances by 7.14%

Comparing eryue0220:fix/lint-a11y-noInteractiveElementToNoninteractiveRole (c292b60) with main (5a1710f)

Summary

⚡ 1 improvements
✅ 102 untouched benchmarks

Benchmarks breakdown

Benchmark main eryue0220:fix/lint-a11y-noInteractiveElementToNoninteractiveRole Change
db_17847247775464589309.json[cached] 14 ms 13.1 ms +7.14%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can you update the changelog?

@github-actions github-actions bot added the A-Changelog Area: changelog label Oct 16, 2024
@ematipico ematipico merged commit ea7d35c into biomejs:main Oct 16, 2024
12 checks passed
@eryue0220 eryue0220 deleted the fix/lint-a11y-noInteractiveElementToNoninteractiveRole branch October 16, 2024 17:13
Conaclos pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 False positive for a11y/noInteractiveElementToNoninteractiveRole
2 participants