fix(useFilenamingConvention): take export renaming into account #4260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4254
To fix the issue, I added to the semantic model the capability of retrieving exports of a given binding.
Unfortunately, this adds 24 bytes of overhead to every binding data.
It should be possible to remove this overhead by distinguishing between read and export references.
However, this is a bigger change than the one I introduced here.
I left it for a future PR, unless the perf impact is visible.
Also, I took the opportunity of introducing a small optimization: instead of iterating over all bindings, we now iterate only over bindings that are actually exported.
Test Plan
I added some tests.