fix(linter): useSortedClasses false positive

CHANGELOG.md

@@ -43,6 +43,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - Fix [#4190](https://github.com/biomejs/biome/issues/4190), where the rule `noMissingVarFunction` wrongly reported a variable as missing when used inside a `var()`  function that was a newline. Contributed by @ematipico
 
+- Fix [#4041](https://github.com/biomejs/biome/issues/4041). Now the rule `useSortedClasses` won't be triggered if `className` is composed only by inlined variables. Contributed by @ematipico
+
 ### Parser
 
 #### Bug Fixes

crates/biome_js_analyze/src/lint/nursery/use_sorted_classes.rs

@@ -165,6 +165,9 @@ impl Rule for UseSortedClasses {
                 let ignore_postfix = should_ignore_postfix(node);
                 let sorted_value =
                     sort_class_name(&value, &SORT_CONFIG, ignore_prefix, ignore_postfix);
+                if sorted_value.is_empty() {
+                    return None;
+                }
                 if value.text() != sorted_value {
                     return Some(sorted_value);
                 }

crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/sort.rs

@@ -166,6 +166,7 @@ pub fn sort_class_name(
             }
         }
     }
+    dbg!(&sorted_classes, &classes_info);
 
     // TODO: make this the last step of compare instead?
 
@@ -207,6 +208,7 @@ pub fn sort_class_name(
         }
     }
 
+    dbg!(&result);
     result
 }
 

crates/biome_js_analyze/tests/quick_test.rs

@@ -13,9 +13,8 @@ use std::{ffi::OsStr, fs::read_to_string, path::Path, slice};
 // use this test check if your snippet produces the diagnostics you wish, without using a snapshot
 #[ignore]
 #[test]
-fn run_test() {
-    let input_file =
-        Path::new("tests/specs/correctness/useExhaustiveDependencies/ignoredDependencies.js");
+fn quick_test() {
+    let input_file = Path::new("tests/specs/nursery/useSortedClasses/issue.jsx");
     let file_name = input_file.file_name().and_then(OsStr::to_str).unwrap();
 
     let (group, rule) = parse_test_path(input_file);
@@ -73,6 +72,7 @@ fn analyze(
     let options = create_analyzer_options(input_file, &mut diagnostics);
     let manifest = load_manifest(input_file, &mut diagnostics);
 
+    dbg!("eree4");
     let (_, errors) =
         biome_js_analyze::analyze(&root, filter, &options, source_type, manifest, |event| {
             if let Some(mut diag) = event.diagnostic() {

crates/biome_js_analyze/tests/specs/nursery/useSortedClasses/issue_4041.jsx

@@ -0,0 +1 @@
+<div className={`${test} ${test}`}/>

crates/biome_js_analyze/tests/specs/nursery/useSortedClasses/issue_4041.jsx.snap

@@ -0,0 +1,9 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: issue_4041.jsx
+---
+# Input
+```jsx
+<div className={`${test} ${test}`}/>
+
+```