Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow/release_lsp): added missing double quotes #377

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(workflow/release_lsp): added missing double quotes #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release_lsp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:

- name: Check intellij version status
if: steps.intellij_version.outputs.changed == 'true'
run: 'echo "Intellij Version change found! New version: ${{ steps.intellij_version.outputs.version }}'
run: 'echo "Intellij Version change found! New version: ${{ steps.intellij_version.outputs.version }}"'

- name: Biome Check version status
if: steps.biome_version.outputs.changed == 'true'
Expand Down
2 changes: 1 addition & 1 deletion editors/intellij/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pluginGroup = com.github.biomejs.intellijbiome
pluginName = Biome
pluginRepositoryUrl = https://github.com/biomejs/biome
# SemVer format -> https://semver.org
pluginVersion = 0.0.2
pluginVersion = 0.0.3
Copy link
Member

@nhedger nhedger Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary since you did not change the plugin, only the workflow?

Or is it to trigger the pipeline?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to trigger the pipeline, otherwise one of us needs to manually trigger the workflow


# Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
pluginSinceBuild = 232
Expand Down