fix(cli): apply offsets for htmlish js file sources #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
cli-htmlish-lint-offsets
branch
from
d80aa45 to
16095ab
Compare
ematipico
approved these changes
Aug 2, 2024
|
@dyc3 I forgot to mention that it would be great to update the changelog |
|
Strange |
|
@davidglezz please don't comment on closed issues. Please open a new issue with a reproduction. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we print diagnostics, previously the spans would be relative to the start of the js code, not to the start of the file. This was causing diagnostics to point to the wrong line for vue, svelte, and astro files.
fixes #3366
Test Plan
Tested manually on some of my own vue/svelte projects. Updated the snapshots.