feat(biome_js_parser): support ts resolution-mode import #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
fireairforce
changed the title
fireairforce
commented
Jul 17, 2024
CodSpeed Performance ReportMerging #3462 will degrade performances by 6.18%Comparing Summary
Benchmarks breakdown
|
|
@fireairforce Are you still interested in the PR? |
|
@Conaclos i will update this later～ |
fireairforce
force-pushed
the
fix-2115
branch
2 times, most recently
from
15d0bc2 to
a741521
Compare
fireairforce
changed the title
fireairforce
force-pushed
the
fix-2115
branch
2 times, most recently
from
d95fc97 to
0d01dd6
Compare
github-actions
bot
added
A-Formatter
fireairforce
force-pushed
the
fix-2115
branch
2 times, most recently
from
e35e118 to
4939375
Compare
fireairforce
commented
Oct 14, 2024
fireairforce
force-pushed
the
fix-2115
branch
from
4939375 to
23ae575
Compare
Conaclos
reviewed
Oct 16, 2024
| @@ -1,3 +1,4 @@ | |||
| import() | |||
| import(...["foo"]) | |||
| import("foo", { assert: { type: 'json' } }, "bar") | |||
| import("foo", { with: { type: 'json' } }, "bar") | |||
There was a problem hiding this comment.
This is now considered correct? We should move it to ok/import_call.js.
There was a problem hiding this comment.
No, that is wrong, it seems that import_attributes only have two params: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#dynamic-import
There was a problem hiding this comment.
Maybe you can provide some reference documentation about this place?
fireairforce
force-pushed
the
fix-2115
branch
from
23ae575 to
e862288
Compare
|
this mr is ready for review~ |
fireairforce
force-pushed
the
fix-2115
branch
from
e862288 to
684abbd
Compare
fireairforce
force-pushed
the
fix-2115
branch
from
684abbd to
f56ef4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes: #2115
Test Plan