Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_formatter): keep parens around infer in unions/intersections #3451

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #3419
This also handle infer in intersections.

Test Plan

I added two tests.

@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jul 16, 2024
@Conaclos Conaclos force-pushed the conaclos/formatter-infer-parens branch from d30c173 to c161f14 Compare July 16, 2024 16:42
Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #3451 will improve performances by 11.17%

Comparing conaclos/formatter-infer-parens (c161f14) with main (60513de)

Summary

⚡ 1 improvements
✅ 107 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/formatter-infer-parens Change
db_2930068967297060348.json[cached] 14.3 ms 12.8 ms +11.17%

@Conaclos Conaclos merged commit 0119290 into main Jul 16, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/formatter-infer-parens branch July 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of necessary parentheses when formatting union of types which include an infer ... extends
2 participants