Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): rule check error messages #3158

Merged
merged 4 commits into from
Jun 10, 2024
Merged

fix(ci): rule check error messages #3158

merged 4 commits into from
Jun 10, 2024

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Jun 10, 2024

Summary

  • The file name format!("{group}/{rule}.js") displayed in the code block diagnostics is misleading, I changed it to rule-doc-code-block.
  • When diagnostics are unexpected or the number of them is greater than 2, only the diagnostics themselves were printed, but the error messages were not. I printed them before ControlFlow::Break.
  • For JSON and CSS rules, we didn't check them when diagnostices were expected but none were printed. This fix helps us catch a failure codeblock in nursery/noUnmatchableAnbSelector.
  • Fixkind mismatch can be catched by the compiler, so I removed the check.

Test Plan

CI should pass when the rule nursery/noUnmatchableAnbSelector is fixed.

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jun 10, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50787 50787 0
Passed 49680 49680 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2087 2087 0
Failed 4447 4447 0
Panics 0 0 0
Coverage 31.94% 31.94% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18217 18217 0
Passed 13961 13961 0
Failed 4256 4256 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

@github-actions github-actions bot added A-Project Area: project L-CSS Language: CSS labels Jun 10, 2024
@Sec-ant Sec-ant force-pushed the ci/fix-rule-check-messages branch from 6b67027 to d3653eb Compare June 10, 2024 13:14
@github-actions github-actions bot added the A-Changelog Area: changelog label Jun 10, 2024
Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #3158 will not alter performance

Comparing ci/fix-rule-check-messages (5f744a1) with ci/fix-rule-check-messages (d3653eb)

Summary

✅ 92 untouched benchmarks

@Sec-ant Sec-ant merged commit 535acc7 into main Jun 10, 2024
15 checks passed
@Sec-ant Sec-ant deleted the ci/fix-rule-check-messages branch June 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants