-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css_formatter): fix CSS nesting whitespace after & trimmed #3061 #3082
Conversation
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #3082 will not alter performanceComparing Summary
|
Should we add extra space after the nesting selector if it has trailing comments? It seems Prettier doesn't handle the case very well 😅 playground link |
Interesting, thank you for that case! Actually, I don't know; it seems that the parser returns an unknown selector if there is a comment between |
Ive converted it to draft because after @ah-yu comment I think that it's a parser issue🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix @denbezrukov! Thank you ❤️
Summary
Close #3061
The problem arose from using the wrong lexer context after processing the '&' token.
Test Plan
cargo test