Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.8.0 #3033

Merged
merged 10 commits into from
Jun 4, 2024
Merged

release: v1.8.0 #3033

merged 10 commits into from
Jun 4, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 31, 2024

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels May 31, 2024
Copy link

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #3033 will not alter performance

Comparing release/1.8.0 (4c01d25) with release/1.8.0 (c210026)

Summary

✅ 92 untouched benchmarks

@github-actions github-actions bot added A-Tooling Area: internal tools L-CSS Language: CSS labels Jun 3, 2024
@ematipico ematipico marked this pull request as ready for review June 3, 2024 10:23
@ematipico ematipico requested review from a team June 3, 2024 10:24
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50793 50793 0
Passed 49686 49686 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2087 2087 0
Failed 4447 4447 0
Panics 0 0 0
Coverage 31.94% 31.94% 0.00%

ts/babel

Test result main count This PR count Difference
Total 667 667 0
Passed 595 595 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.21% 89.21% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18206 18206 0
Passed 13954 13954 0
Failed 4252 4252 0
Panics 0 0 0
Coverage 76.65% 76.65% 0.00%

@Conaclos
Copy link
Member

Conaclos commented Jun 3, 2024

Do you think that useImportRestrictions is really mature? We recently introduced a new option, and it is not documented yet. Also, I have the impression that the rule is missing some long-term vision.

@ematipico
Copy link
Member Author

We did? Why wasn't that documented?

I promoted the rules because it's been there for quite some time, and it's been used already by other projects

@Conaclos
Copy link
Member

Conaclos commented Jun 3, 2024

We did? Why wasn't that documented?

Oh actually it is not merged yet: #2977

However, the rule has already an option under another form and is undocumented.
I think we should delay the stabilization of the rule.

@arendjr
Copy link
Contributor

arendjr commented Jun 3, 2024

To add to the objections for that specific rule, it's also quite confusing we have both noRestrictedImports and useImportRestrictions. The PR @Conaclos linked is actually for the former.

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good 👍

@ematipico
Copy link
Member Author

Commit 2171ff8 (#3033) downgrades useImportRestrictions

@ematipico ematipico merged commit 378c05e into main Jun 4, 2024
15 checks passed
@ematipico ematipico deleted the release/1.8.0 branch June 4, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants