feat(cli): add github and junit reporters
#3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
CodSpeed Performance ReportMerging #3029 will not alter performanceComparing Summary
|
anonrig
approved these changes
May 31, 2024
| @@ -43,6 +43,7 @@ dashmap = { workspace = true } | |||
| hdrhistogram = { version = "7.5.4", default-features = false } | |||
| indexmap = { workspace = true } | |||
| lazy_static = { workspace = true } | |||
| quick-junit = "0.4.0" | |||
There was a problem hiding this comment.
Should this be on the root cargo.toml, and have workspace = true? Although, I'm ok with here as well, since I assume this crate will logically always belong to biome_cli.
There was a problem hiding this comment.
Yeah, it only belongs to biome_cli so there's so need to make it available to the entire workspace
ematipico
force-pushed
the
feat/github-reporter
branch
from
d71a8c9 to
dd4ca40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
githubandjunitreporters.The
junitreporter is heavily inspired by how Ruff does it.Test Plan
I added new test cases