fix(lint/noEmptyBlockStatements): fix false positive when considering constructors using property parameters #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #3009 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
05-27-fix_lint_noemptyblockstatements_fix_false_positive_when_considering_constructors_using_property_parameters
branch
2 times, most recently
from
ef9e59c to
ccaa249
Compare
ah-yu
reviewed
May 28, 2024
crates/biome_js_analyze/src/lint/suspicious/no_empty_block_statements.rs
Outdated
Show resolved
Hide resolved
dyc3
force-pushed
the
05-27-fix_lint_noemptyblockstatements_fix_false_positive_when_considering_constructors_using_property_parameters
branch
from
ccaa249 to
8d2c21d
Compare
Conaclos
approved these changes
May 28, 2024
crates/biome_js_analyze/src/lint/suspicious/no_empty_block_statements.rs
Outdated
Show resolved
Hide resolved
I'll go ahead and do that in this PR. |
dyc3
force-pushed
the
05-27-fix_lint_noemptyblockstatements_fix_false_positive_when_considering_constructors_using_property_parameters
branch
from
8d2c21d to
48716db
Compare
Conaclos
reviewed
May 28, 2024
crates/biome_js_analyze/src/lint/suspicious/no_empty_block_statements.rs
Outdated
Show resolved
Hide resolved
… constructors using property parameters
dyc3
force-pushed
the
05-27-fix_lint_noemptyblockstatements_fix_false_positive_when_considering_constructors_using_property_parameters
branch
from
48716db to
23d78d5
Compare
Conaclos
approved these changes
May 28, 2024
dyc3
deleted the
05-27-fix_lint_noemptyblockstatements_fix_false_positive_when_considering_constructors_using_property_parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typescript has a syntax extension called parameter properties. See: https://www.typescriptlang.org/docs/handbook/2/classes.html#parameter-properties
This PR makes it so that this rule ignores constructors that use this feature.
fixes #3005
Test Plan
Added snapshot test