fix(formatter): never format biome.json with trailing commas #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we accept trailing commas for |
|
It appears that other implementations allow for trailing commas in From a quick search: |
dyc3
force-pushed
the
05-27-fix_formatter_never_format_biome.json_with_trailing_commas
branch
from
04d955d to
d777a43
Compare
dyc3
force-pushed
the
05-27-fix_formatter_never_format_biome.json_with_trailing_commas
branch
from
d777a43 to
eb33352
Compare
Conaclos
approved these changes
May 28, 2024
dyc3
deleted the
05-27-fix_formatter_never_format_biome.json_with_trailing_commas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ensures that trailing commas is always disabled when formatting
biome.jsonorbiome.jsonc. Failing to do so could result in biome formatting it's own configuration such that it's no longer valid json, and would not get parsed. The full context is in #2990.fixes #2990
Test Plan
I added a cli test for this scenario.
cargo test -p biome_cli always_disable_trailing_commas_biome_json