-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve analyze guide #2910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! I left some fixes and suggestions.
recommended: false, | ||
} | ||
} | ||
``` | ||
|
||
### Custom Visitors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some words about fix_kind
and sources
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it in a second Pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a line that is not edited:
_Biome_ follows a naming convention according to what the rule do: |
according to what the rule do:
=> according to what the rule does:
Co-authored-by: unvalley <[email protected]> Co-authored-by: Victorien Elvinger <[email protected]>
CodSpeed Performance ReportMerging #2910 will not alter performanceComparing Summary
Benchmarks breakdown
|
Summary
Adds more information in the contribution guidelines.
I added:
declare_node_union
let else
I moved the sections around, in order to create a flow that made sense:
Before, it didn't make sense.
Test Plan
Proofread.
Here's the rendered file, the code diff doesn't help.