refactor(biome_analyze): derive Applicability from FixKind
#2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #2885 will not alter performanceComparing Summary
|
ematipico
reviewed
May 16, 2024
dyc3
force-pushed
the
05-16-refactor_biome_analyze_derive_applicability_from_fixkind_
branch
from
06cadd2 to
bb416a4
Compare
ematipico
approved these changes
May 16, 2024
dyc3
deleted the
05-16-refactor_biome_analyze_derive_applicability_from_fixkind_
branch
|
Merging the PR makes main failed: https://github.com/biomejs/biome/actions/runs/9114244240/job/25057688478 |
|
Taking a look now. |
|
Submitted a fix in #2890. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FixKindandApplicabilityline up one to one, and need to remain in sync. This addsRuleMetadata::to_applicability()and aimpl From<FixKind> for Applicability.I'll follow up this PR with another codemod to change all the rules to call this function instead.
Related to: #2799
Test Plan
It compiles.