feat(css_formatter): use format_number_token utils for css number #2769
Conversation
| + a: 1E1; | ||
| + a: 1E+1; | ||
| + a: 1E-1; | ||
| + a: 1.E1; | ||
| + a: .1E1; | ||
| + a: 1.1E1; | ||
| + a: 1.1E0010; | ||
| + a: .1E+0010; | ||
| + a: .1E-0010; |
There was a problem hiding this comment.
I'm not sure this is correct. It should print with lowercase e
There was a problem hiding this comment.
Yes, you're right; it's problematic how GitHub displays changes. This code was about the differences between our formatting and Prettier's, but it has now been removed.
However there is a problem with a number parsing and I'm unsure how to handle it better.
a: 1.;
a: 0.e60;
our parser can't parse these number because according to spec: https://drafts.csswg.org/css-syntax-3/#consume-number
If the next 2 input code points are U+002E FULL STOP (.) followed by a digit, then:
Consume the next input code point and append it to number part.
While the next input code point is a digit, consume it and append it to number part.
Set type to "number".
CodSpeed Performance ReportMerging #2769 will not alter performanceComparing Summary
|
Summary
Use
format_number_tokento format CSS numbers like we do for JS/JSON numbersTest Plan
cargo test -p biome_css_formatter